alaspooryorick

Shit like the following problem I discovered is why I get paid very well:

Lines 2822ff of FAPGLBTM.C are below. The call to VMMInsOrdElem effectively creates a copy of pBitmap and puts it into the formset's bitmap list. That copy is what gets passed into the driver. Any changes I make to it (and specifically, setting prtInfo.oth.data) will not affect the cached object, only the copy. Why was this code added in place of the VMMMoveElem that's commented out?

elemH = VMMCacheLocateElemByVers(bitmapCacheH,
buffer,
&ver);
if ( elemH != VMMNULLHANDLE )
{
bitmapH = FAPPARM2VMMH(VMMCacheElemParm1(elemH));
if ( bitmapH != VMMNULLHANDLE )
{
glbtmplH = FAPGlobBitmapList(formsetH);
pBitmap = FAPGLOBBITMAPPTR(bitmapH);
/*
VMMMoveElem(glbtmpH,glbtmplH);
VMMSortOrdList(glbtmplH,(VMMSORTNOTIFY)NULL);
*/

glbtmpH = VMMInsOrdElem(glbtmplH,
pBitmap,
(size_t)pBitmap->desc.len,
&found);

pBitmap = FAPGLOBBITMAPPTR(glbtmpH);
pBitmap->flag |= FFLAG_CACHED;
pBitmap->desc.parentH = formsetH;
if ( CREATEMSGFLAG(glbtmpH) ) {
FAPSendObjectMessage(glbtmpH,
FAP_MSGCREATE,
FAPPARMDEF,
FAPPARMDEF);
}
return glbtmpH;
}
}